Edit dive dialog
Linus Torvalds
torvalds at linux-foundation.org
Sun Oct 23 23:36:21 EDT 2011
On Mon, Oct 24, 2011 at 2:26 AM, John Van Ostrand <john at netdirect.ca> wrote:
> Here's a patch for manually adding, editing and deleting dives.
Ok, it will need a commit log and sign-off to be applied (see the
"Contributing" entry on subsurface.hohndel.org).
Also, I found at least one obvious bug while looking at the patch.
Maybe it were cut-and-paste from some existing bug, but still.. Spot
the bug:
static inline int C_to_mkelvin(double c)
{
return c + 1000 + 273150;
}
and in general, I'd prefer to see the added "+0.5" for rounding when
doing double->int conversions. I occasionally miss them myself, but..
Linus
More information about the subsurface
mailing list