First time subsurace usage surprises

Miika Turkia miika.turkia at gmail.com
Wed Aug 1 20:21:43 PDT 2012


On Wed, Aug 1, 2012 at 9:08 PM, Pierre-Yves Chibon <pingou at pingoured.fr> wrote:
> On Tue, 2012-07-31 at 13:58 -0700, Linus Torvalds wrote:
>> > I miss a feature to change attributes of several dive logs at the
>> same time.
>>
>> I do too. I'd love for the multi-selection to work for all the
>> equipment issues etc. It doesn't, and it's non-trivial to fix.
>>
>> Some of the equipment stuff is very tightly linked with the "current
>> dive" thing, and worse, some of it is linked to not just the dive, but
>> the actual printing of the dive data in the current view. You can see
>> that when you do a "Add new dive", and get the cylinder equipment
>> thing: it's actually getting the data from the dive that was displayed
>> when you selected "Add new dive". The creation of the model for the
>> cylinder is incestuous with the actual display routines.
>>
>> That needs fixing, since it causes actual buggy behavior even with
>> that single dive case, but it's nasty gtk internal stuff, and I didn't
>> get around to fixing it properly when I did the "add new dive" stuff.
>
> I spent sometime today trying to get a basic thing working.
> With this, you can select several dives, right-click and change with
> this the rating, divemaster and buddy.
> It is far from perfect but I thought that it might still be interesting,
> at least as a basis to improve.
> If the approach is approved, then we can add support for the tanks.
>
> Let me know what you think of this.

Looks like a good start to me. Just a few comments after a very brief test:

- If all the selected dives have same info in them (like Buddy),
pre-filling that information would be useful
- By default empty fields should not clear already filled information
from dives. E.g. I might have inserted Dive Master manually for three
out of 5 dives and want to add single buddy to them all leaving DM
unchanged.
- Other information that should be included:
  - Location
  - Dive trip (currently not supported in subsurface but this would be
useful for dive trip based statistics, similar to the yearly stats
patch a while back)
  - Cylinder size
  - Weight system
  - Notes (write e.g. info on wet suit for a bunch of dives)

miika


More information about the subsurface mailing list