Comments on latest changes

Linus Torvalds torvalds at linux-foundation.org
Sat Aug 18 10:52:22 PDT 2012


On Sat, Aug 18, 2012 at 9:45 AM, Linus Torvalds
<torvalds at linux-foundation.org> wrote:
> On Fri, Aug 17, 2012 at 10:55 PM, Miika Turkia <miika.turkia at gmail.com> wrote:
>
>> - When a dive is selected and I click on add dive manually - how about
>>   presetting the calendar to that date?
>
> Well, that would be easy enough. I'm not sure it's all that useful,
> though. Do you really want the time of the previous dive? But anyway,
> it would look something like the attached patch. Test it out. What do
> other people think?

Actually, if we do this, we certainly shouldn't default to the same
time as the selected dive (rounded down to the closest 5 minutes at
that).

It would make more sense to defaulting to the *end* of the selected
dive, together with a sane surface time. Say one hour.

So *if* we do this (and I'm still not entirely sure it really makes
sense), it might be something like this attached patch instead.

                        Linus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: application/octet-stream
Size: 1679 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20120818/6870cbd3/attachment.obj>


More information about the subsurface mailing list