Weird editing dives

[Dirk Hohndel]

Dirk Hohndel <dirk at hohndel.org> writes:

> Dirk Hohndel <dirk at hohndel.org> writes:
>
>> Jacco van Koll <jacco.van.koll at gmail.com> writes:
>>
>>> Gents,
>>>
>>> When I try to edit details of another dive, after I have edited another
>>> dive, The dialog opens the information from the previous edited dive...
>>> Very annoying?
>>
>> Very likely sign of a bug...
>>
>> I can reproduce this here - shouldn't be too hard to figure out.
>
> Oh yeah. Someone confused DIVE_NUMBER and DIVE_INDEX. I'll need to
> carefully read through the code to figure out where this went wrong.
> It definitely used to work.

This will work around your immediate bug. I need to run for an
appointment, edit_dive_info is broken right now and needs to be fixed
(so don't try to manually add dives right now)

Linus, I'll create a proper fix and send a pull request tonight.

/D

diff --git a/divelist.c b/divelist.c
index ef34b06..b34f7c1 100644
--- a/divelist.c
+++ b/divelist.c
@@ -1090,7 +1090,7 @@ static void row_activated_cb(GtkTreeView *tree_view,
                collapse_expand(tree_view, path);
                return;
        }
-       edit_dive_info(get_dive(index));
+       edit_multi_dive_info(index);
 }
 
 void add_dive_cb(GtkWidget *menuitem, gpointer data)