request for comments

[Ďoďo]

I like the trip feature but I do believe that automatic grouping can
be problematic. So manual grouping would be for me also the best
solution. I also understand that it is lot of work.

Dodo

On Wed, Aug 22, 2012 at 1:55 PM, Jacco van Koll
<jacco.van.koll at gmail.com> wrote:
> On Wed, Aug 22, 2012 at 7:38 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>>
>>
>> Linus (and everyone else),
>>
>> Here's a start at implementing the trips
>>
>> I don't think this should be pulled (for one thing it contains tons of
>> un-ifdef-ed printf calls). But I would like to know what you (and
>> others) think about the design decisions that I made here so far, before
>> I go any further in the implementation.
>>
> I think that the idea is neat, but make it 'user choice' in one of the
> menu's. For myself, I would like to see just a list of dives and not a list
> of trips. But that is personal. Being able to switch between those two,
> would be very nice.
>
>>
>> So with this the functionally is equivalent to what we have (I think)
>> but it now saves (and loads) the explicit trip data structures to/from
>> the XML file and maintains them as a GList in memory.
>>
>> What I really would like feedback on is
>>
>> - the on disk format
>>
>> I am dropping the duration and am adding a "tripentry='TRUE'" property
>> to the dive tag (which I then ignore when reading - how's that for
>> consistency). I am keeping the negative trip numbers to make it easier
>> to search in the XML files
>>
>> e.g., for a trip with four dives in Hoodsport:
>>
>> <dive number='4' tripid='-21' date='2010-12-04' time='10:38:00'
>> tripentry='TRUE'>
>>   <location>Sund Rock, Hoodsport, WA, USA</location>
>> </dive>
>>
> Most divers I know, only make one or two dives a week. Sometimes on a single
> day, most of the time one on Wednesday and/or Sat/Sunday. Then the option to
> put in a trip entry-flag by hand, would be nice. But that will be a lot of
> work, I think...
>
>>
>> Anyway, please let me know what you think.
>
>
> As I said, it's neat. But when importing new dives, the auto-numbering
> stopped, so I had to renumber the dives by hand. Maybe this has something to
> do with your new code, I don't know. But, as stated, make the Trip-option a
> user-choice....
>
>>
>> /D
>>
> Regards,
> Jacco
>
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>