another RFC for trip handling

Linus Torvalds torvalds at linux-foundation.org
Sun Aug 26 16:21:44 PDT 2012


On Sun, Aug 26, 2012 at 3:28 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> It then creates time based groups and stores them in the XML file as
> something like
>
> <trip number='12' date='2012-08-23' time='09:25:31'>
>   <location>San Diego, CA, USA</location>
> </trip>

I haven't looked at the code yet, but do you really want to make the
trips give the *minute* they start? That sounds a bit crazy.

How about just making it a starting day. And make the location be an
attribute, so that you can do it like

 <trip number='12' date='2012-08-23' location='San Diego, CA, USA' \>

which will be a whole lot more readable in the xml file.

Btw, what's the point of the trip number? That seems like a totally
meaningless number. I get the feeling that it is left-overs from when
you indexed things by integers..

So just a

  <trip date='2012-08-23' location='San Diego, CA, USA' \>

sounds like the right data format (code we can easily change later,
data formats should be something we strive to get right from the
start. Sure, we can fix them up later too, but it's just better to do
it early rather than late)

            Linus


More information about the subsurface mailing list