Crash when editing trip summary

[Lubomir I. Ivanov]

On 4 December 2012 22:19, Linus Torvalds <torvalds at linux-foundation.org> wrote:
> On Tue, Dec 4, 2012 at 11:15 AM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>>
>> this one should be applied instead of the previous patch.
>> i've made some smaller fixes along the way..
>
> Looks ok to me, although I'd suggest doing the
> "remember_tree_state();" part *before* starting to merge the trips.
>
> I think part of your other changes are due to this.
>
> But this already looks better than your first patch.
>

ok, just sent an update:
[PATCH] Merge trips without modifying the GTK tree

i've moved the remember_tree_state() before the trip list update,
but left the two small safety checks in there just in case.

> Btw, the way you do your attachments likely makes it inconvenient for
> Dirk to apply. Git has various helper tools to apply patches directly
> from email, but they tend to want to have the commit message in the
> *body* of the patch, and the summary line in the *subject* of the
> email.
>
> You can override the summary line, but then you should make it the
> first line of the body of the email, and have the "Subject:" prefix to
> let git know that this replaces the actual subject of the email.
>
> And then you can do a triple-dash thing, and add your comments (that
> you do *not* want in the commit message) to below that.
>
> See for example
>
>   http://lists.hohndel.org/pipermail/subsurface/2012-November/001629.html
>
> (which also has From/Date overrides) or
>
>   http://lists.hohndel.org/pipermail/subsurface/2012-November/001618.html
>
> (which has the actual patch in the attachment, but the commit message
> in the body of the email).
>

i've been using format-patch + send-email only for quite some time,
but in here was pretty much sending the patches as attachment for
people to test if this is in fact good logic or not.
just resent using these tools, yet i must admit i couldn't get the
"in-reply-to" to feature of end-email to work for me, or perhaps i
don't understand it, thus the [PATCH]
email ends up in a new thread.

lubomir
--