lots of changes - please read as this may break your build

[Henrik Brautaset Aronsen]

Henrik Brautaset Aronsen wrote:
> Dirk Hohndel wrote:
>> Please take a look and test to make sure I didn't break anything while
>> merging these changes.
>
> Hi Dirk.
>
> The device selector is missing the device subtype in the download
> dialogue, and when I exit the dialogue, Subsurface crashes:
>
> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
> 0 libsystem_kernel.dylib 0x00007fff950c0212 __pthread_kill + 10
> 1 libsystem_c.dylib 0x00007fff94898af4 pthread_kill + 90
> 2 libsystem_c.dylib 0x00007fff948dcdce abort + 143
> 3 libglib-2.0.0.dylib 0x000000010fde6ebf g_assertion_message + 303
> 4 libglib-2.0.0.dylib 0x000000010fde7335 g_assertion_message_expr + 69
> 5 libgtk-quartz-2.0.0.dylib 0x000000010f5a3f12 gtk_tree_store_get_path +
> 194
> 6 libgtk-quartz-2.0.0.dylib 0x000000010f5a22cb
> gtk_tree_selection_iter_is_selected + 187
> 7 subsurface 0x000000010f0ccf4f check_selection_cb + 127

I also got these when running from the shell:

(subsurface:12582): Gtk-CRITICAL **: GtkWidget 
*gtk_combo_box_new_with_model(GtkTreeModel *): assertion 
`GTK_IS_TREE_MODEL (model)' failed

(subsurface:12582): GLib-GObject-WARNING **: invalid (NULL) pointer instance

(subsurface:12582): GLib-GObject-CRITICAL **: g_signal_connect_data: 
assertion `G_TYPE_CHECK_INSTANCE (instance)' failed

(subsurface:12582): Gtk-CRITICAL **: void gtk_box_pack(GtkBox *, 
GtkWidget *, gboolean, gboolean, guint, GtkPackType): assertion 
`GTK_IS_WIDGET (child)' failed

(subsurface:12582): Gtk-CRITICAL **: void 
gtk_cell_layout_pack_start(GtkCellLayout *, GtkCellRenderer *, 
gboolean): assertion `GTK_IS_CELL_LAYOUT (cell_layout)' failed

(subsurface:12582): Gtk-CRITICAL **: void 
gtk_cell_layout_set_cell_data_func(GtkCellLayout *, GtkCellRenderer *, 
GtkCellLayoutDataFunc, gpointer, GDestroyNotify): assertion 
`GTK_IS_CELL_LAYOUT (cell_layout)' failed

(subsurface:12582): Gtk-CRITICAL **: void 
gtk_combo_box_set_active(GtkComboBox *, gint): assertion 
`GTK_IS_COMBO_BOX (combo_box)' failed

(subsurface:12582): Gtk-CRITICAL **: gboolean 
gtk_combo_box_get_active_iter(GtkComboBox *, GtkTreeIter *): assertion 
`GTK_IS_COMBO_BOX (combo_box)' failed

(subsurface:12582): Gtk-CRITICAL **: void 
gtk_combo_box_set_model(GtkComboBox *, GtkTreeModel *): assertion 
`GTK_IS_COMBO_BOX (combo_box)' failed

(subsurface:12582): Gtk-CRITICAL **: void 
gtk_combo_box_set_active(GtkComboBox *, gint): assertion 
`GTK_IS_COMBO_BOX (combo_box)' failed

(subsurface:12582): Gtk-CRITICAL **: void 
gtk_combo_box_set_model(GtkComboBox *, GtkTreeModel *): assertion 
`GTK_IS_COMBO_BOX (combo_box)' failed

(subsurface:12582): Gtk-CRITICAL **: void 
gtk_combo_box_set_active(GtkComboBox *, gint): assertion 
`GTK_IS_COMBO_BOX (combo_box)' failed

(subsurface:12582): Gtk-CRITICAL **: void 
gtk_combo_box_set_model(GtkComboBox *, GtkTreeModel *): assertion 
`GTK_IS_COMBO_BOX (combo_box)' failed

(subsurface:12582): Gtk-CRITICAL **: void 
gtk_combo_box_set_active(GtkComboBox *, gint): assertion 
`GTK_IS_COMBO_BOX (combo_box)' failed
**
Gtk:ERROR:gtktreestore.c:522:GtkTreePath 
*gtk_tree_store_get_path(GtkTreeModel *, GtkTreeIter *): assertion 
failed: (G_NODE (iter->user_data)->parent != NULL)
Abort trap: 6

Cheers,
H