lots of changes - please read as this may break your build

[Dirk Hohndel]

On Dec 12, 2012, at 6:35 AM, Dirk Hohndel wrote:

> 
> On Dec 12, 2012, at 12:10 AM, Henrik Brautaset Aronsen wrote:
> 
>> Dirk Hohndel wrote:
>>> Please take a look and test to make sure I didn't break anything while
>>> merging these changes.
>> 
>> Hi Dirk.
>> 
>> The device selector is missing the device subtype in the download dialogue, and when I exit the dialogue, Subsurface crashes:
> 
> Interesting… I can reproduce that here on a Mac. Strangely the product dialog does show up on Linux… but apparently one can trigger a crash there as well.

Just pushed a fix. We ended up referencing index -1 of an array.

It is indeed quite interesting how resilient Linux is to stupid memory bugs. Mac OS X seems to be much more aggressive when it comes to failing. And that isn't necessarily a bad thing as it helps us find bugs.

Thanks for the report

/D