[PATCH 1/5] Fixed a couple of memory leaks related to the download dialog

Lubomir I. Ivanov neolit123 at gmail.com
Sun Dec 16 14:26:34 PST 2012


From: "Lubomir I. Ivanov" <neolit123 at gmail.com>

In render_dc_vendor() and render_dc_product(), there is
no need to allocate memory for the texts that are about to
be added in the combo box trees. Most GTK widgets seem to make
copies of the passed text to them, using g_strdup() and
automatically release said memory when a widget is destroyed.

Signed-off-by: Lubomir I. Ivanov <neolit123 at gmail.com>
---
 gtk-gui.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gtk-gui.c b/gtk-gui.c
index 5a35b39..834d199 100644
--- a/gtk-gui.c
+++ b/gtk-gui.c
@@ -1663,7 +1663,7 @@ void render_dc_vendor(GtkCellLayout *cell,
 	const char *vendor;
 
 	gtk_tree_model_get(model, iter, 0, &vendor, -1);
-	g_object_set(renderer, "text", strdup(vendor), NULL);
+	g_object_set(renderer, "text", vendor, NULL);
 }
 
 void render_dc_product(GtkCellLayout *cell,
@@ -1677,7 +1677,7 @@ void render_dc_product(GtkCellLayout *cell,
 
 	gtk_tree_model_get(model, iter, 0, &descriptor, -1);
 	product = dc_descriptor_get_product(descriptor);
-	g_object_set(renderer, "text", strdup(product), NULL);
+	g_object_set(renderer, "text", product, NULL);
 }
 
 static void dive_computer_selector_changed(GtkWidget *combo, gpointer data)
-- 
1.7.11.msysgit.0



More information about the subsurface mailing list