[PATCH] Convert deco info from JDiveLog to Subsurface

Dirk Hohndel dirk at hohndel.org
Wed Dec 19 13:32:01 PST 2012


Will do all that. Once I'm back from the beach. It's our last day in 
Maui so it might be late before I turn on the computer!

/D



On December 19, 2012 10:36:56 AM Linus Torvalds 
<torvalds at linux-foundation.org> wrote:
> On Wed, Dec 19, 2012 at 9:43 AM, Miika Turkia <miika.turkia at gmail.com> wrote:
> >
> > I have been looking at the differences on the xslt conversion and
> > subsurface produced output quite a bit and the attached xslt is the
> > best I can currently come up with. A few additional eyes might spot
> > the bug.
>
> Ok, I found it.
>
> The bug is that the jdivelog xslt conversion doesn't add the
> "<divecomputer>" xml tags.
>
> And strictly speaking, they really shouldn't be needed, so the xslt is
> not to blame. But what happens is that the stop information at xml
> parse time is only cleared by the divecomputer entries, so if the XML
> lacks them, we will bleed stop data from one dive to the next. So that
> part was definitely a core subsurface bug, not the xslt.
>
> And with your xslt time corrections, and this patch, things now seem
> to work correctly for me. I didn't do any exhaustive testing, but at
> least there's nothing really obviously wrong that I see.
>
> Dirk - please add an "Acked-by:" from me to Miika's patch, and here's
> an additional patch to fix the other problem. Make up some changelog
> and add my sign-off, I'll go back to looking at the kernel..
>
> Thanks,
>               Linus




More information about the subsurface mailing list