[PATCH 5/5] Only remember a DC nickname if the user has pressed OK

Dirk Hohndel dirk at hohndel.org
Thu Dec 20 17:14:52 PST 2012


"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:
>
> hm, but how about not wanting to set a nickname at all?
>
> from what i understood the "cancel" button has to be removed and a
> "ask me next time" button should be placed instead of it as they would
> do the same.
> so "Ask me next time" is a persistent "no-action" button (same as the
> top right "x"), until the users presses "OK" to actually set a
> nickname.
> i may have got that wrong...
>
> attachment = patch

Sorry it took me so long to get back to you.

I still don't like this, as set_dc_nickname() gets called for every new
dive. So if I say "ask me next time" then I'll get asked again, right
away. Also, the text in the dialogbox is now of course wrong.

Obviously both of these are easy to fix, but I really think I want to
stay where we are with the current code (set nickname or cancel to get
just the model) and rely on the to-be-written UI to manage our nickname
database instead.

/D


More information about the subsurface mailing list