[PATCH 5/5] Only remember a DC nickname if the user has pressed OK

[Linus Torvalds]

On Fri, Dec 21, 2012 at 9:36 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> I already store them in the config. What about adding a settings block
> before the <dives></dives>? Something like
>
> <settings>
> <divecomputer deviceid='abc' nickname='my computer' />
> <divecomputer deviceid='def' nickname='my backup computer' />
> <autogroup value='TRUE' />  <--- remember, we wanted to make this per file
> <other settings ... />
> </settings>
> <dives>
> <program name='subsurface' version='1'></program>
> <trip date='...

Yeah, I think we'd want to do that for other things anyway. And
perhaps consider moving some of our other config options in there too.

> I'm not sure I agree with that last part. I think we should ask if the
> user wants to name a dive computer the first time we see it - and that
> is either when loading an XML file that has a deviceid and we don't have
> a matching nickname, or when downloading from a new computer for the
> first time...

So at least for me, I don't actually see the point of a nick-name
unless I have multiple dive computers of the same type. The
"dc->model" is about as good a nickname as I can come up with.

So I'd rather see subsurface asking me only if it sees two dive
computers with the same model, but different deviceid. At that point,
nicknames suddenly matter ("Old Vyper Air").

                Linus