settings section in XML file and trips issue

Dirk Hohndel dirk at
Thu Dec 27 11:07:00 PST 2012

Linus Torvalds <torvalds at> writes:

> On Wed, Dec 26, 2012 at 7:58 PM, Dirk Hohndel <dirk at> wrote:
>> The second commit fixes a crash that is caused by some serious issues in
>> the trip handling code. Linus, you have rewritten this quite heavily, so
>> maybe you want to look at it?
>> Simply import both your and my dives with DEBUG_TRIP defined and you'll
>> see things go wrong big time.
> Ho humm.. Our dive trip handling shouldn't care so deeply about the
> dive trips being sorted any more, although the find-by-date things
> (used mainly by the gtk tree handling) do get confused.
> I'll take a look at it,

Linus, what about this fix?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-trip-handling-when-importing-XML-files.patch
Type: text/x-patch
Size: 5309 bytes
Desc: not available
URL: <>

More information about the subsurface mailing list