[PATCH] Make add_dc_to_string() skip redundant entries

Linus Torvalds torvalds at linux-foundation.org
Fri Dec 28 08:38:47 PST 2012


There is no point writing out divecomputer nicknames that do not exist
(or that match the dive computer model), so don't.

Also, make the function to do this static to save-xml.c, which is the
only user (I initially didn't _find_ the function to create the XML
string because it was illogically hidden in gtk-gui.c), and change the
calling convention to be more direct (pass in a string and return a
result, rather than modify a "pointer to string").

Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
---

This makes the xml look better again. Now I have an empty "settings"
section, but that's better than having pointless noise in it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-add_dc_to_string-skip-redundant-entries.patch
Type: application/octet-stream
Size: 4410 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20121228/095905ae/attachment.obj>


More information about the subsurface mailing list