Behavior about saving on exit

Pierre-Yves Chibon pingou at pingoured.fr
Wed Jul 18 22:42:08 PDT 2012


On Wed, 2012-07-18 at 15:43 -0700, Linus Torvalds wrote:
> On Wed, Jul 18, 2012 at 2:48 PM, Pierre-Yves Chibon <pingou at pingoured.fr> wrote:
> >
> > Attached are four patches, the first one is cosmetic,
> 
> It's wrong. You have some broken tab-size settings.
>
> Tabs are 8 characters. If you have them set to anything else, fix your editor.

Should be fixed

> Your commit messages are also oddly formatted, with 100-character lines.

Fixed

> Other than that, it looks pretty reasonable.

Thanks,

Regards,
Pierre
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Global-replacement-of-spaces-by-tabs.patch
Type: text/x-patch
Size: 3305 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20120719/66e45512/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-When-the-file-has-been-opened-rely-on-it-to-save.patch
Type: text/x-patch
Size: 3077 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20120719/66e45512/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Allow-to-cancel-while-quitting-on-modified-data.patch
Type: text/x-patch
Size: 2827 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20120719/66e45512/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-a-Save-As-entry-in-the-menu.patch
Type: text/x-patch
Size: 3161 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20120719/66e45512/attachment-0007.bin>


More information about the subsurface mailing list