[subsurface] Freediving tweaks (#104)

[Maximilian Güntner]

Hi everyone,

so here is my "real" email to the "real" mailing list ;).
I updated the pull request today following Linus' remarks. I added
a zoom button to the "Log" menu so that the user can switch between
zoomed-in and normal mode. I assigned the shortcut "Ctrl + 0" for that action,
since it is already established in serveral other applications (e.g. Mozilla Firefox).

I completely disabled scaling depending on max depth/max time, since in general
not every apnea dive has to be deeper and not every instructor dive shallower than 30 ft.

The pre-patch behaviour is preserved, with subsurface limiting the x-axis to
at least 30 minutes when not zoomed in.
Users are still able to quickly distinguish short dives from normal ones when
browsing the dive log.
If the user now wishes to zoom, the user can do that by 
either pressing (Ctrl + "0") or clicking on Log->Toggle Zoom.

Link to pull request: https://github.com/torvalds/subsurface/pull/104

Maximilian


On Saturday 09 June 2012 10:30:50 Linus Torvalds wrote:
> Hey, this pull request looks pretty good, it looks like either you did
> something special, or github is really improving.
> 
> That said, I still really want to see your real email somewhere.. And
> we do have a real mailing list (subsurface at hohndel.org), which should
> be cc'd too for things like this..
> 
> But the real reason I won't pull is that the indentation for some of
> that new code looks horrible. And it's mixed in with the normal
> indentation and K&R code. Can you please fix that up?
> 
> Also, one reason we *don't* show short dives with a big scale is that
> quite often when doing things like divemastering for an OW class, the
> dives are really short and shallow. So I've got dives that are just a
> couple of minutes and go down all the way to 7 feet or so. I really
> *want* them to look small and not at all like real dives in the
> profile window.
> 
> So I wonder if you could make it trigger not just on time, but on max
> depth. With perhaps a "zoom" button to change scales? So that when you
> move from dive to dive, you see "oh, that was a short dive" without
> ever having to look at what the scale was.
> 
>                      Linus
>