[PATCH] fix subsurface.desktop

Linus Torvalds torvalds at linux-foundation.org
Mon May 7 08:31:59 PDT 2012

On Mon, May 7, 2012 at 2:19 AM, Khalid El Fathi <khalid at elfathi.fr> wrote:
> You should decide if you want to use this patch.

I have nothing against the patch, but please read the bottom of the
README file: I want nice changelogs for patches, and I need the
SIgned-off-by: line (see the web link that explains it).

This is not just because "that's how the Linux kernel does it" - good
descriptions of patches are important, and the sign-off is so that
we'll never have any copyright questions in the future.

You might also take a look at the (longer) kernel documentation
version of how to submit patches:


even if it's a bit dated in some ways (much better to use 'git diff -p
--stat' that to do "diff -uprN", so that section (1) is dated)


More information about the subsurface mailing list