[PATCH] fix subsurface.desktop
dirk at hohndel.org
Mon May 7 10:25:12 PDT 2012
On Mon, 07 May 2012 19:08:51 +0200, Khalid El Fathi <khalid at elfathi.fr> wrote:
> On 05/07/2012 05:31 PM, Linus Torvalds wrote:
> > I have nothing against the patch, but please read the bottom of the
> > README file: I want nice changelogs for patches, and I need the
> > SIgned-off-by: line (see the web link that explains it).
> > This is not just because "that's how the Linux kernel does it" - good
> > descriptions of patches are important, and the sign-off is so that
> > we'll never have any copyright questions in the future.
> > You might also take a look at the (longer) kernel documentation
> > version of how to submit patches:
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=Documentation/SubmittingPatches
> > even if it's a bit dated in some ways (much better to use 'git diff -p
> > --stat' that to do "diff -uprN", so that section (1) is dated)
> Hi Linus,
> Ok, so here's the new patch. Sorry for missing.
> .''`. Khalid El Fathi <khalid at elfathi.fr>
> : :' : GPG: 4096R/9368CAEC
> `. `'` www.elfathi.fr
> From: Khalid El Fathi <khalid at elfathi.fr>
> This desktop entry lists a category that is not one of the registered Main or
> Additional Categories in the FreeDesktop specification.
> Refer to http://standards.freedesktop.org/menu-spec/1.0/apa.html for
Yep - I had used the Category used in an opensuse example. Utility would
in fact have been the correct one.
> Signed-off-by: Khalid El Fathi <khalid at elfathi.fr>
Acked-By: Dirk Hohndel <dirk at hohndel.org>
> subsurface.desktop | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/subsurface.desktop b/subsurface.desktop
> index 6fdec10..12eb679 100644
> --- a/subsurface.desktop
> +++ b/subsurface.desktop
> @@ -6,5 +6,5 @@ Comment=manage and display dive computer data
> subsurface mailing list
> subsurface at hohndel.org
More information about the subsurface