[PATCH 2/2] Move events and samples into a 'struct divecomputer'

Linus Torvalds torvalds at linux-foundation.org
Fri Nov 23 21:57:54 PST 2012

On Fri, Nov 23, 2012 at 5:41 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
> I really like these two patches and I like the direction they are taking
> us. I wonder if it wouldn't have been better to just assume that there
> are (let's say) a maximum of five dive computers and have the structures
> set up for that - because we'll have another pretty big change coming
> when we switch to that...

I was thinking of making it a linked list of dive computers, with NULL
being the marker for "no samples" (right now we look at the sample
count of the one dive computer we have). But we'll see.

Anyway, I found a bug in the "force download" case for my
(over-)simplified "just copy the dive computer info over". Will send a
patch in a separate email.


More information about the subsurface mailing list