[PATCH 4/6] Start merging dives by keeping the dive computer data from both dives

Dirk Hohndel dirk at hohndel.org
Sun Nov 25 13:11:38 PST 2012


Linus Torvalds <torvalds at linux-foundation.org> writes:
>
> Also, note that we do *not* do the "find_sample_offset()" any more when
> we merge two dives that happen at the same time - since we just keep
> both sets of dive computer data around.
>
> But we keep the function to find the best offset around, because we may
> well want to use it later when *showing* the dive, and trying to match
> up the different sample data from the multiple dive computers associated
> with the dive.
>
> Because of that, this causes warnings about the now unused function.

In other cases like that we either did a #if around the function
definition or we have an if (0) { } clause around a call to the
function.

Is there a reason why you didn't do either of those two things?

/D


More information about the subsurface mailing list