[PATCH] Fix typos and shell for MacOSX packaging scripts

Dirk Hohndel dirk at hohndel.org
Tue Oct 2 20:15:39 PDT 2012

Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com> writes:
> Here's an incipient cleanup attempt, maybe controversial.  Should I
> continue?

In general I like where you are taking this. I /think/ you did the right
thing (haven't looked at every single line, yet) and did the formatting
change in its own commit that changed NOTHING ELSE but just the

On the other changes you have some of them where I'm not sure if your
replacement code is actually the more portable one, but then I am
definitely not shell scripting expert.

I thought, for example, that the whole 

> -if test "x$GTK_DEBUG_LAUNCHER" != x; then

thing was indeed because some shells don't deal with empty strings
when doing comparisons.

But let's face it - we don't want to go totally overboard with this.
What I'm aiming for is a well documented, easily readable shell script
that is reasonably POSIX compliant and will survive if a different POSIX
shell ends up being used.

I'm inclined to take your commits as they are after I had a chance to
test them on my Mac (only have access to my Linux system right this

Thanks for working on this, Cristian!


More information about the subsurface mailing list