[PATCH] Fix typos and shell for MacOSX packaging scripts

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Wed Oct 3 12:32:14 PDT 2012


On Wed, 3 Oct 2012, Cristian Ionescu-Idbohrn wrote:
>
> In that particular case, these forms (all posix) are equivalent:
>
> 	if test -n "$GTK_DEBUG_LAUNCHER"; then
> 	if test "$GTK_DEBUG_LAUNCHER"; then
> 	if [ "$GTK_DEBUG_LAUNCHER" ]; then
>
> The later is the one I would use throughout.

Looking at the code...  The middle form is already used.  See line 46 on
master:

	if test "$APPLELANGUAGES"; then

I see no point in being inconsistent.


Cheers,

-- 
Cristian


More information about the subsurface mailing list