[PATCH 1/2] Provide a method to use unicode command line arguments on Windows

Lubomir I. Ivanov neolit123 at gmail.com
Wed Oct 3 14:29:22 PDT 2012

On 3 October 2012 18:30, Dirk Hohndel <dirk at hohndel.org> wrote:
> "Lubomir I. Ivanov" <neolit123 at gmail.com> writes:
>> while the patches are valid for single files and also fix the saving
>> and loading, apparently i've forgot to test wildcards for unicode
>> filenames, which fails.
> Both of these are things that developers often do. I doubt we'll have a
> lot of people calling the Windows binary on the command line and even
> fewer will do so with wildcards. But we should at least try to implement
> this if possible.

i'm sorry for the delay, here is a patch update [1/2] that should also
handle wildcard arguments on Windows.
its a bit hacky but glib's documentation recommend it and also i can
see this in other projects.

the new implementation is tested by calling:
".\subsurface.exe .\dives\*"
where ".\dives" contains some extra unicode filenames.

other OS should be once again unaffected, but i still wouldn't mind if
someone has a Windows XP installation to give this a test.

the second patch in the sequence remains unchanged and should also apply:
[PATCH 2/2] Use GLib's g_fopen() and g_open() when working with files

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Provide-a-method-to-use-unicode-command-line-argumen.patch
Type: application/octet-stream
Size: 4536 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20121004/e14af95c/attachment.obj>

More information about the subsurface mailing list