[PATCH] Fix typos and shell for MacOSX packaging scripts
dirk at hohndel.org
Thu Oct 4 01:51:57 PDT 2012
Henrik Brautaset Aronsen <subsurface at henrik.synth.no> writes:
>> Thing is, as it stands, '#!/bin/bash' is required. The script would break
>> if run under shells not supporting bashisms.
> Thing is, I can't understand what's wrong with using bash here. Bash
> will be in OSX "forever", and we get the (fairly important) added bonus
> of easy merges when launcher.sh changes.
> If we change subsurface.sh to something very different from launcher.sh,
> we lose that.
Much as I hate to admit it, I think I have to reverse my earlier
position and instead agree with Henrik.
Cristian, I may have sent you off on a wild goose chase - maybe we are
better off keeping this shell script pretty much the same as launcher.sh.
It is used only on Mac - if Apple ever breaks things for us, then
launcher.sh will be changed to accomodate that by the people maintaining
the gtk Mac port... and that will be much easier to track (as will be
changes that may be needed by MacOS 10.9 or 10.10) if we keep
modifications to a minimum.
My apologies for encouraging you to go down the path of making this more
portable and readable - I will keep it as is for now.
More information about the subsurface