[PATCH] Fix typos and shell for MacOSX packaging scripts

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Thu Oct 4 02:41:29 PDT 2012

On Thu, 4 Oct 2012, Dirk Hohndel wrote:
> Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn at axis.com> writes:
> > I had a _quick look_ at launcher.sh and it looks different from
> > subsurface.sh in many parts.
> It shouldn't. Upstream may have moved since the last release (0.7.0) was
> built, but the diff between the launcher.sh in the release I used to
> build the bundle and subsurface.sh is one line (I commented out the
> incorrect DYLD_LIBRARY_PATH that breaks the MacPorts version of Gtk)
> plus seven white space fixes.

Right.  That may be it.  I looked at master, and master showed me

> > I also found just one bashism in launcher.sh:
> >
> > 	possible bashism in launcher.sh line 125 (should be '.', not 'source'):
> > 	  source "$bundle_res/environment.sh"
> >
> > which is easyly fixed with a '. "$bundle_res/environment.sh"'.  All
> > other bashisms in subsurface.sh are new edits.  Diverging from
> > launcher.sh in that way will not make merging to subsurface.sh easy.

Nevermind, I was maybe beating the wrong cow.

> Thanks again for working on this. It's been a learning experience
> for me.

Any time.  My pleasure :)



More information about the subsurface mailing list