Crash under Fedora 17

Dirk Hohndel dirk at hohndel.org
Sun Oct 7 05:02:28 PDT 2012


Henrik Brautaset Aronsen <subsurface at henrik.synth.no> writes:
>> b272fb8c (Lubomir I. Ivanov        2012-10-04 23:52:09 +0300  680)              if (divelist_font)
>> b272fb8c (Lubomir I. Ivanov        2012-10-04 23:52:09 +0300  681)                      free((void *)divelist_font);
>>
>> but if no font is set, this is what linux.c does:
>>
>> void subsurface_ui_setup(GtkSettings *settings, GtkWidget *menubar,
>>                  GtkWidget *vbox, GtkUIManager *ui_manager)
>> {
>>          if (!divelist_font)
>>                  divelist_font = DIVELIST_DEFAULT_FONT;
>>
>> So we are handing a string literal to free. Not good.
>>
>> MacOS does the same, so my guess is that Henrik has a font in his
>> config...
>
> Nope, I deleted the preferences before testing.

Odd - I wonder how macos is fine passing the pointer to a string literal
to free...

Anyway, I am just about to push out 2.0.1 - this is way to easy to hit
for people trying out Subsurface for the first time. Please use 2.0.1 to
build all binaries.

/D


More information about the subsurface mailing list