Localization

Dirk Hohndel dirk at hohndel.org
Thu Oct 11 06:10:50 PDT 2012


Henrik Brautaset Aronsen <subsurface at henrik.synth.no> writes:

> Den 11.10.12 14:56, skrev Dirk Hohndel:
>> Switching back to German I notice that there the divelist headers aren't
>> localized, either (and I am CERTAIN that they were at some point during
>> the testing), but the menus are indeed all localized.
>
> Weirdness!

I may have been CERTAIN, but I also was WRONG. I missed one spot where
string literals are used as initializers and therefore marked with
N_(). And in those cases we need to call gettext (or here: _() ) when
that variable is used. So no, this wasn't localized correctly in
German. I just THOUGHT it was.

Fix was just pushed.

>> Looking at this in more detail I realized that the menu entries that
>> aren't localized in Norwegian are the ones where we use GTK_STOCK_xxx
>> and then NULL as text for the menu entry. Apparently those default texts
>> are missing from Gtk's Norwegian localization? It would be easy enough
>> to simply have all the texts there and localize them, I guess.
>
> Nice find! I'll add them.

Thanks - but that requires us to merge the additional strings into the
.po files. Please remember my earlier comment that I /really/ would like
you to do one commit with just the changed line numbers, etc (if any -
there may be none since this is right after the initial conversion, in
which case this request is of course moot). And THEN a second commit
that adds the new texts and their translations...

/D


More information about the subsurface mailing list