French translation

Jnoel jnoel at sissiou.net
Mon Oct 15 08:34:54 PDT 2012


Thank you for taking time to explain to me.
I've amended the commit with signed-off-by and re-create a pool request
on the gettext branch

Le lundi 15 octobre 2012 +AOA 07:45 -0700, Dirk Hohndel a +AOk-crit :

+AD4 On Oct 15, 2012, at 7:35 AM, Jnoel wrote:
+AD4 
+AD4 +AD4 Yes I've made some few spelling corrections in the po file of Pierre-Yves directly from github fr+AF8-FR po file.
+AD4 +AD4 I've just made a pull request after corrections... Is that the correct approach ?
+AD4 
+AD4 Sort of. Linus and I both aren't fans of the github pull request implementation. It messes up email addresses and makes it harder to communicate.
+AD4 Additionally, your pull request is relative to master (which usually is fine, but since I haven't merged the gettext branch, yet, it looks wrong).
+AD4 Worse, you don't have a Signed-off-by: line in the commit - we really need those.
+AD4 
+AD4 I think the best way to do things is to amend your commit with a Signed-of-by: line and then re-create the pull request from the command line:
+AD4 
+AD4 git request-pull gettext https://github.com/jnoel/subsurface patch-1
+AD4 
+AD4 /D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http:+AC8ALw-lists.hohndel.org+AC8-pipermail+AC8-subsurface+AC8-attachments+AC8-20121015+AC8-72468e05+AC8-attachment.html>


More information about the subsurface mailing list