[PATCH] info.c: Make sure we only edit when there is dive selection

Dirk Hohndel dirk at hohndel.org
Tue Oct 23 09:19:29 PDT 2012


"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:

> On 23 October 2012 18:11, Dirk Hohndel <dirk at hohndel.org> wrote:
>> The rest of the patch looks good
>>
>
> i realized there is no confirmation when deleting dives and trips.
> this was present when deleting from the "dive info" dialog/window.

personally I hate the confirmation dialogs... but since we don't have an
undo function I guess they are a necessary evil.

> just sent a couple of patches for that:
> [2/3] removes the delete functionality from info.c
> [3/3] adds delete confirmation to divelist.c
>
> there is some overlapping, but [1/3] is still kind of relevant due to
> the "edit" fixes.

I'll take a look at them tonight.

/D


More information about the subsurface mailing list