help wanted from Windows and Mac experts...
dirk at hohndel.org
Mon Oct 29 13:33:27 PDT 2012
On Oct 29, 2012, at 1:29 PM, Lubomir I. Ivanov wrote:
> On 29 October 2012 22:23, Dirk Hohndel <dirk at hohndel.org> wrote:
>>> i'm assuming it tries to update the progress bar while the dialog is closed.
>>> perhaps it would be best to disable the UI buttons in the dialog until
>>> the error report is shown?
>> Yuck. I think the better solution would be to reliably kill the other
>> thread if the window is closed - this should be the same as hitting
>> cancel, right?
> i think its possible to listen for:
> in download_dialog() and kill the thread from there.
> another small issue is with gtk-gui.c: import_dive_computer()
> if i enter a non-existing COM5 port and press OK the dialog closes, due to:
> if (!error)
> return NULL;
> perhaps there should be error reporting when a port / device is not accessible?
Both sound like good ideas. Are these things you'll implement or do I need to add them to my todo list?
I pushed out your patch to the branch (but will merge that into master, soon)
More information about the subsurface