pull-request: trip management, next try
Henrik Brautaset Aronsen
subsurface at henrik.synth.no
Sun Sep 2 23:45:48 PDT 2012
At 02.09.12 21:16, Dirk Hohndel wrote:
> I don't think so. I think trip haters should have the ability to turn
> the auto generation of trips off.
I don't hate trips. I just want to be in control of them. Especially: I
want to be able to group my dive trips into groups, and keep the other
dives outside any groups (at the top level), at the same time. That
doesn't seem to be possible now.
At 03.09.12 07:00, Dirk Hohndel wrote:
> here's the next attempt. This adds the menu item that Linus asked for
> and it fixes the crash that Miika found.
If I import the test dives ("Autogroup" off), ("Automatic grouping" on),
the dives are grouped. When I enable "Autogroup", the groups disappear.
If I disable it again, the groups reappear. Shouldn't it be the other
way around?
Also, Subsurface crashed when I removed a topmost dive from a group:
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 org.hohndel.subsurface 0x000000010735887e
move_dive_between_trips + 430 (divelist.c:1297)
1 org.hohndel.subsurface 0x0000000107358fe6
insert_trip_before + 1078 (divelist.c:1378)
2 org.hohndel.subsurface 0x00000001073591bb
remove_from_trip_cb + 219 (divelist.c:1416)
3 libgobject-2.0.0.dylib 0x0000000107fa3104
g_closure_invoke + 308
Henrik
More information about the subsurface
mailing list