pull-request: trip management, next try

Mon Sep 3 08:27:46 PDT 2012

Den 03.09.12 17:14, skrev Dirk Hohndel:
> On Sep 3, 2012, at 7:28 AM, Dirk Hohndel wrote:
>>> Also, Subsurface crashed when I removed a topmost dive from a group:
>>>
>>> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
>>> 0   org.hohndel.subsurface            0x000000010735887e move_dive_between_trips + 430 (divelist.c:1297)
>>> 1   org.hohndel.subsurface            0x0000000107358fe6 insert_trip_before + 1078 (divelist.c:1378)
>>> 2   org.hohndel.subsurface            0x00000001073591bb remove_from_trip_cb + 219 (divelist.c:1416)
>>> 3   libgobject-2.0.0.dylib            0x0000000107fa3104 g_closure_invoke + 308
>> Haven't seen this before. Will investigate.
> Actually, I cannot seem to reproduce this. Can you send me the xml file you used and the precise steps to reproduce?

It's not easy, it just seemed to happen randomly.  But I managed to 
reproduce it, using your trip3 branch:

- start Subsurface
- import all test dives
- remove dive 15 and 14 from their trips
- order by date
- remove dive 16 from its trip
- crash!

Henrik