Bug report: Crash on adding dive

Henrik Brautaset Aronsen subsurface at henrik.synth.no
Mon Sep 10 11:27:31 PDT 2012


Den 10.09.12 20:18, skrev Dirk Hohndel:
> Ok, I root-caused this and it showed a corner case in my existing
> algorithm to assign new dives to existing trips. I'll admit that this
> was a corner case that was embarrassingly easy to hit but that was
> actually quite hacky to work around. So I reconsidered my initial design
> decision and went back to a single pass through the dive_list and to
> figuring out if there is a matching trip while walking that list the
> first time.
>
> As it happens, the new code seems much more straight forward and
> certainly much more readable to me :-)
>
> Henrik and/or Miika, would you please test and send an ACK if you could?

Looks good, Dirk.  Thanks!

H


More information about the subsurface mailing list