request for review and testing: default file name

[Dirk Hohndel]

Henrik Brautaset Aronsen <subsurface at henrik.synth.no> writes:

> Den 10.09.12 02:43, skrev Dirk Hohndel:
>> This is reasonably well tested on Linux and somewhat tested on
>> MacOS. Completely untested (beyond compliling) on Windows.
>>
>> I /think/ it implements a reasonable logic:
>>
>> if filenames are given, everything is like today.
>> if no filename is given, it attempts to open the default file and sets
>> it (even if the open failed) as the existing file name (so a first time
>> user will get that as the default name when savin).
>> The preferences dialog allows a change of the default file location.
>>
>> I'd especially appreciate feedback from Mac and Windows users - and of
>> course general code review.
>
> Hi Dirk.
>
> I can't quite get it to work:
>
> 1) Open Subsurface
> 2) In Preferences, verify that ~/Library/Application 
> Support/Subsurface/henrik.xml is selected
> 3) Log » Import » XML file » test1.xml
> 4) Save
> 5) Quit
> 6) Re-open Subsurface
> 7) No log is opened?!
>
> There's nothing written to ~/Library/Application 
> Support/Subsurface/henrik.xml either (but the folder is created). And if 
> I leave out 4), Subsurface doesn't ask me to save.


Yes. Two bugs. Incorrect folder permissions. Incorrect "things were
changed" logic. Both fixed in my latest code that I'll send out for
review, soon.

/D