request for review and testing: default file name

[Lubomir I. Ivanov]

On 11 September 2012 00:58, Dirk Hohndel <dirk at hohndel.org> wrote:

> I have NOT implemented the nicknames / storage of other information
> relative to the nickname used, yet.
>
> But I think I have fixed all the other bugs in this code that have been
> reported.
>
> The following changes since commit b6812946319080699f6071656f09d402d23d3e46:
>
>   Merge branch 'print_selection' of http://ambre.pingoured.fr/cgit/subsurface (2012-09-06 12:48:02 -0700)
>
> are available in the git repository at:
>
>
>   git://git.hohndel.org/subsurface.git defaultfile
>
> for you to fetch changes up to b4d55c8b598b648acda0f8107868b8753283c72e:

a couple of things i've noticed:

once again windows is different - "io.h" has mkdir accepting only one
parameter :-(:
a naive solution in the attached patch.

-------

i've also replaced in the patch:
http://developer.gnome.org/glib/2.30/glib-Doubly-Linked-Lists.html#g-list-free-full

with the inlined alternave:
g_list_foreach(dive_trip_list, (GFunc)free, NULL);
g_list_free(dive_trip_list);

once again my version on debian 6.0.x has libraries up-to-date yet outdated.
i guess i have to suggest against API which has the "Since <some ver>"
text and <some ver> is fairly recent on documentation webpages.

another current problem i have on linux is
"gtk_tree_path_get_indices_with_depth" explained / solved in a recent
patch:
[PATCH 2/2] Better compatibility with older GTK and Cairo

-----

on windows i've noticed that once the user browses out of the "app
dir", there is not way to return to it, since it is hidden.
perhaps a reset button (reverting back to
$appdata/roaming/subsurface/user_name.xml" is a solution.
or simply showing hidden files/folders in the browse dialog.

lubomir
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch0.patch
Type: application/octet-stream
Size: 1726 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20120911/fa564f40/attachment.obj>