request for review and testing: default file name

Dirk Hohndel dirk at hohndel.org
Mon Sep 10 18:46:03 PDT 2012


"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:
>
> a couple of things i've noticed:
>
> once again windows is different - "io.h" has mkdir accepting only one
> parameter :-(:
> a naive solution in the attached patch.

Yeah, that solution won't work for me. I don't want #ifdefs in the code.
I guess I'll have to do platform specific functions in linux.c/macos.c/window.c
unless I can find another API function that is consistent between the
platforms and works for our purposes. I guess I shouldn't be surprised
that Windows isn't POSIX compatible for functions like this given that
the access controls on the filesystem level work quite differently.

> i've also replaced in the patch:
> http://developer.gnome.org/glib/2.30/glib-Doubly-Linked-Lists.html#g-list-free-full
>
> with the inlined alternave:
> g_list_foreach(dive_trip_list, (GFunc)free, NULL);
> g_list_free(dive_trip_list);
>
> once again my version on debian 6.0.x has libraries up-to-date yet outdated.
> i guess i have to suggest against API which has the "Since <some ver>"
> text and <some ver> is fairly recent on documentation webpages.

That was my mistake. I didn't notice that g_list_free_full was new in
2.28. I'll need to fix that.

> another current problem i have on linux is
> "gtk_tree_path_get_indices_with_depth" explained / solved in a recent
> patch:
> [PATCH 2/2] Better compatibility with older GTK and Cairo

I'll look through that tonight.

> on windows i've noticed that once the user browses out of the "app
> dir", there is not way to return to it, since it is hidden.
> perhaps a reset button (reverting back to
> $appdata/roaming/subsurface/user_name.xml" is a solution.
> or simply showing hidden files/folders in the browse dialog.

Adding buttons like that to the dialog is not easy. I guess I could set
the "show hidden" option. I'll play with it. Worst case the user can
always hit cancel and then click on the button again to start picking
the right file...

/D


More information about the subsurface mailing list