latest defaultfile branch

Dirk Hohndel dirk at hohndel.org
Thu Sep 13 10:57:17 PDT 2012


Ok, implemented and both commits are pushed.

Please check the latest defaultfile branch and make sure that my
implementation actually fixes the problem you were trying to fix.

Thanks for catching that!

/D

Dirk Hohndel <dirk at hohndel.org> writes:

> "Lubomir I. Ivanov" <neolit123 at gmail.com> writes:
>
>> On 13 September 2012 01:50, Dirk Hohndel <dirk at hohndel.org> wrote:
>>>
>>> Pushed to the defaultfile branch with minor changes.
>>>
>>> /D
>>
>> thanks,
>> here are two more:
>>
>> mem leaks fixes (?) + a small window focus issue.
>
> I really don't like the way the preferences dialog is suddenly a global
> variable. That seems very hacky. Especially since Gtk gives us an API to
> get to the dialog that is our ancestor:
>
> preferences = gtk_widget_get_ancestor(w, GTK_TYPE_DIALOG)
>
> So I'll implement that differently, but I'll take the other changes from
> this commit...
>
> /D


More information about the subsurface mailing list