[PATCH 2/2] Fixing up the code as Dirk suggested

Dirk Hohndel dirk at hohndel.org
Fri Sep 14 12:52:47 PDT 2012


Miika Turkia <miika.turkia at gmail.com> writes:

> On Tue, Sep 11, 2012 at 7:59 AM, Miika Turkia <miika.turkia at gmail.com> wrote:
>> On Tue, Sep 11, 2012 at 7:31 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>>> One thing I noticed is that the current code doesn't refresh the display
>>> when the chosen units are changed in the preferences. That's clearly not
>>> a show stopper (the user could simply close the statistics window and
>>> reopen it) but it may be something to look into for the future.
>>
>> I'll take a look into it.
>
> This patch should take care of refreshing the statistics window.

It does. Thanks for fixing this. I took it as is and did a follow up
patch that changed some of the things that I didn't like about the way
you implemented this (and actually, something you did in the previous
version already that's in master).

You can see the latest branch that I have staged for Linus to pull at

git://git.hohndel.org/subsurface.git for-master

or look at 

http://git.hohndel.org/?p=subsurface.git;a=log;h=refs/heads/for-master

to get a web interface

/D


More information about the subsurface mailing list