[PATCH] Use gtk_tree_model_get_value() to get the index and date of a dive

[Dirk Hohndel]

"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:

> On 19 September 2012 01:52, Dirk Hohndel <dirk at hohndel.org> wrote:
>>
>> I don't get the part where this would be "safer". Can you point to any
>> documentation that states this?
>
> well, unfortunately, in "my book" only. :-(
> i have some experience with truly broken vararg / cdecl compiler
> implementations...

Ah. We use so many vararg functions in subsurface... if we have to work
around that - oh my. Every printf/scanf function, etc...

> the fact that I was skeptical about this particular bit from the start
> tells nothing of course and also the root-cause remains unclear, but i
> doubt there is an easy fix.

I understand.

>> I'm obviously thrilled if this does indeed fix the bugs Miika has been
>> seeing - but I'll admit that I'm deeply unhappy with this. The whole
>> get_value set of functions are just so horribly atrocious... they make
>> for truly ugly and unreadable code (IMNSHO)
>
> i completely agree!
> ...interesting to see an alternative.

Well, I don't have one, so much as I hate it... if this really does fix
Miika's issue, I guess I'll take the patch and comment the heck out of
it. Maybe hide the ugliness in a macro or something. I'll have to play
with this for a while.

/D