[PATCH] Use gtk_tree_model_get_value() to get the index and date of a dive

Dirk Hohndel dirk at hohndel.org
Tue Sep 18 17:29:45 PDT 2012


"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:

> On 19 September 2012 03:19, Dirk Hohndel <dirk at hohndel.org> wrote:
>> "Lubomir I. Ivanov" <neolit123 at gmail.com> writes:
>>> everything else is could be semantics more or less, i'd think.
>>> "gcc -Wextra -pendantic -std=c99" will spit 500+ lines of such if we
>>> really want to tackle them.
>>
>> Well, see my other mail. I think I found a potential smoking gun passing
>> something that came from malloc to g_free. I haven't looked at glib's
>> g_free implementation but my gut feeling is that this could cause some
>> major pain.
>
> hmm, could be.
> AFAIK it only checks if NULL before calling free(), but there could be
> more indeed.
>
> i will do some more tests based on the "cppcheck" report tomorrow, as well.

I think I just pushed out a commit that fixes everything that seemed
relevant. Let's make sure we still see the Ubuntu problem with that one.

If yes, then let's try the gcc -Wextra -pedantic -std=c99 and see if it
comes up with something we missed so far...

/D


More information about the subsurface mailing list