[PATCH] Use long instead of int when retrieving DIVE_DATE via gtk_tree_model_get

Lubomir I. Ivanov neolit123 at gmail.com
Wed Sep 19 15:53:58 PDT 2012


^ this patch is a replacement to the recent:
[PATCH] Use gtk_tree_model_get_value() to get the index and date of a dive

dirk i hope you see now what i meant by "varargs are usually less safer" :-).

what i did to debug this one was pretty much stare at GTK and GLib's
sources (ubuntu 12.04) for a couple of hours finding no bugs, other
than that their code is not very pretty, with mixed indentations and
also that GLib has huge macros in headers that will certainly bloat.
the solution on the other hand was at a very obvious location...

why this bug was local to only one x64 OS, i believe was due to a
memory "issue", rather than a different glib implementation e.g. of
G_VALUE_LCOPY, which is one of many examples how not to write macros
as a C programmer, was the same all around.

lubomir
--


More information about the subsurface mailing list