[PATCH] Use long instead of int when retrieving DIVE_DATE via gtk_tree_model_get

Linus Torvalds torvalds at linux-foundation.org
Wed Sep 19 21:48:49 PDT 2012

On Wed, Sep 19, 2012 at 5:41 PM, Linus Torvalds
<torvalds at linux-foundation.org> wrote:
> I pushed out an RFC commit into the "time-function" branch, if
> somebody wants to take a look. Hmm?

Btw, Lubomir, since I obviously never actually saw the problem, mind
giving that "time-function" branch a test on your setup?

I just pushed out the equivalent fix in that branch (and I'd pushed
out your "int"->"long" fix on master earlier). The original commit in
that time-function branch only did the 64-bit time, it didn't actually
fix the use of the wrong type. And then I had to go to my kids school
function, so I only now pushed out the thing that fixes the problem
you found there. Mind testing?

(Miika too, I guess, since he was the original reporter).

I'm not entirely sure that it's even worth worrying about the whole
year-2038 bug, but since the new 64-bit time handling should also get
rid of the worry about the non-reentrancy of gmtime(), it does seem to
solve multiple issues in one go. Which is a sign of something good.


More information about the subsurface mailing list