[PATCH] Use gtk_tree_model_get_value() to get the index and date of a dive

Linus Torvalds torvalds at linux-foundation.org
Thu Sep 20 12:59:35 PDT 2012

On Thu, Sep 20, 2012 at 7:56 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Sep 20, 2012, at 5:42 AM, Jef Driesen wrote:
>> BTW, I'm not sure whether you are aware of the fact that you shouldn't call gtk+ functions from threads other than the main thread. Doing this happens to work on X11, but it's known to break on windows. Subsurface is breaking this rule when updating the progress bar from the libdivecomputer thread. The correct way to do this is to update the progress bar from the main thread with a call to the g_idle_add function.
> Linus, is this something you could fix in the next few days? This is your code and it might be easier for you to come up with an elegant fix.

Ok. There's now a 'single-threaded-gui' branch pushed out.

It should merge cleanly with the dive-trip-and-64bit-time branch, I


More information about the subsurface mailing list