[PULL REQUEST] Delete multiple dives

Dirk Hohndel dirk at hohndel.org
Sat Sep 22 22:20:23 PDT 2012


"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:

> The following changes since commit c4c636fb4ffa942f282d57556a579de311b96c43:
>
>   Fix missing save of (almost empty) cylinder information (2012-09-21 21:01:42 -0700)
>
> are available in the git repository at:
>
>   git at github.com:neolit123/subsurface.git delmulti
>
> for you to fetch changes up to 4d9abf6e8ee465728d1ff1308e18265557dbca42:
>
>   Added the functionality to delete selected (multiple) dives (2012-09-23 01:18:25 +0300)
>
> ----------------------------------------------------------------
> Lubomir I. Ivanov (2):
>       Added different delete label when right clicking multiple drives
>       Added the functionality to delete selected (multiple) dives
>
>  divelist.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 55 insertions(+), 14 deletions(-)

Not bad, but doesn't quite get it right, yet.

Think about the case where deleting dives changes the starting point of
a trip... it's important that at any point of time the dive_trip->when
== dive->when for the first (chronoligically) dive in a trip. So if you
delete the first trip you always need to update that start time of the
dive trip.

/D


More information about the subsurface mailing list