[PATCH 2/2] tree_selected_foreach: ingore trips in the selection

Lubomir I. Ivanov neolit123 at gmail.com
Fri Sep 28 15:15:10 PDT 2012


On 28 September 2012 23:37, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> BTW: I believe your patch is incorrect - delete_single_dive should only
> decrement amount_selected if the dive was selected, right?
>

erm, i guess so.

> Also, what's the point of the return value. You ignore it at one caller
> site, and in the other case we KNOW that there's a dive there...
>

you can ignore that patch as it had debug code in it.
i-- was the only problem.

> Ok, I'll rework this into something that I like and push it so we can
> get some broader testing of it. I really don't want to make a lot of
> functional changes anymore at this stage...
>

i can help testing the delete functionality later on.

lubomir
--


More information about the subsurface mailing list