[PULL REQUEST] A couple of small mods post the delmulti rework

Lubomir I. Ivanov neolit123 at gmail.com
Sat Sep 29 09:57:18 PDT 2012


On 29 September 2012 19:28, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Sep 29, 2012, at 9:16 AM, Lubomir I. Ivanov wrote:
>> On 29 September 2012 18:36, Dirk Hohndel <dirk at hohndel.org> wrote:
>>> "Lubomir I. Ivanov" <neolit123 at gmail.com> writes:
>>>
>>>> 1) i was able to find a mysterious bug in the divelist that shows
>>>> some of the dives which are _not_ in trips without bold text in the indexes.
>>>> this was on windows, but no idea how to reproduce it at this point.
>>>> i'm pretty sure this was not imaginary.
>>>
>>> Somehow the tripflag of the dive is still set to either IN_TRIP or
>>> ASSIGNED_TRIP. I'll do some more staring at the code to see if there's a
>>> spot where this could stick around when removing a dive from a trip.
>>>
>>> Do you have any idea what you did when you got there? What kind of
>>> things were you testing?
>>
>> import dives + create/remove trip + import dives again.
>
> Hmm. Maybe fill_dive_table did something silly when you imported more dive.
> Or did you import the same dives?
>

i think i've re-imported some of the dives that were already in the
list (basically grabbing a selection of "recent")
at least, this was what i was trying to reproduce it with.

lubomir
--


More information about the subsurface mailing list