[PULL REQUEST] A couple of small mods post the delmulti rework

Lubomir I. Ivanov neolit123 at gmail.com
Sat Sep 29 17:02:40 PDT 2012


On 30 September 2012 02:45, Dirk Hohndel <dirk at hohndel.org> wrote:
> Dive-> equipment
>
> /D

yeah...this makes no sense to me at all as GtkButton inherits from GtkWidget.

in equipment.c:

i pass "button" as a GTK_WIDGET to:
edit_weightsystem_dialog(GTK_WIDGET(button)...

receive it as "w"
edit_weightsystem_dialog(GtkWidget *w,...

then get the widget parent as:
parent = gtk_widget_get_ancestor(w, GTK_TYPE_DIALOG);

so what the assert is telling me is that a "GtkButton" is not a
"GtkWidget", which makes no sense.

the patch works on 2 OS with 3 different versions of GTK.
so this solves a crash on Ubuntu, but now opens an OSX / GTK
issue...fun times. :-)

lubomir
--


More information about the subsurface mailing list