Qt branch

[Dirk Hohndel]

Alberto Mardegan <mardy at users.sourceforge.net> writes:

> Hi! I hope that the apologetic tone of this message won't be too
> depressing :-)

Unlikely :-)

> As I should have known, free time and a 8 months old baby are
> incompatible, so my plan of spending 20+ hours working on Subsurface
> during these holidays failed miserably. :-(

And I don't think anyone expected this to really work. At least not
those of us with kids :-)

> I think I'd be just delaying everyone else if you are depending on my
> work, so I'd like to propose another approach: I have a branch here
> which does just the setting up of the build system for Qt, which I think
> is ready for inclusion in the main repository (in a separate branch, of
> course):
>
> https://github.com/mardy/subsurface/commits/qt

You are way too hard on yourself. You already helped a great deal to get
us started. I'll take a look at this later and will push it out
(assuming I find no show-stopper issues).

> People with some Qt experience (and whoever else wants to try oneself)
> can start developing on it already.
> I will anyway continue working on my "wip" branch as time permits,
> mostly to show how I would do things. I don't see much point in porting
> all the menu actions now, for instance; I've ported one of them, just as
> an example, and someone else can work on the rest.
> So, feel free to have a look at my "wip" branch on github (there's some
> new stuff there!), copy stuff from there, extend/complete it and push it
> to the official repository. I hope that in this way we can distribute
> the work and actually get something done.

Cool

> If you need help on specific topic or would like me to start porting a
> specific part of Subsurface, let me know; I can easily find some minutes
> to hack on stuff -- it's prolonged time the one I lack :-)

Which I believe is true for most of us, most of the time. The most
consistent time I find to hack on Subsurface is when Linus and I are on
dive trips and have time after diving and not much else to do :-)

> BTW, is there a code review process setup? I would happily review
> patches on the Qt GUI -- I think that this could be helpful to get more
> people active.

We don't have a formal code review process. It's a pretty small project
after all. I usually review code before pulling it into master - others
look at things that are being pushed out and catch things that I miss.

Lubomir usually looks after the Windows port, Henrik makes sure things
work on Mac. Etc.

/D