Qt Mainwindow skeleton done.

Dirk Hohndel dirk at hohndel.org
Tue Apr 2 08:56:19 PDT 2013


Tomaz Canabrava <tcanabrava at kde.org> writes:
>> A few comments:
>>
>> - don't feel like you have to create a 1:1 copy of the Gtk application
>>   There are quite a few things in the current design that should be
>>   improved upon. For example the Menus that we use right now make very
>>   little sense (there's this Filter menu with just one entry... that
>>   hardly anyone ever uses... then there is way too much stuff bunched
>>   together in the Log menu)
>>
>
> It's just eayser when I never ever used the project before, I don't know
> what's good or bad, a 1:1 copy is faster, then I can make changes later.

Understood. I just wanted to make sure it is clear that some things we
feel very strongly about (keeping the non-UI logic in C, coding style,
builds on Linux/Windows/Mac, etc), wheras others we are aware need
improvement (Dive Notes widget, Menu structure, etc).

> I'm already doing a big refactoration on the files ( instead of one big
> interface file, lots of smaller ones ), so the code will be easyer to
> change in the future.

See our other discussion :-)

>>   I think this needs some careful thoughts and design...
>>   The big groups are (I think)
>>
>>   File  Log  Divecomputer  Web  View  Planner  Help
>
> As soon as the discussion about the menu is finished, I'll change it on the
> mainwindow.
>>
>>   The Filter stuff should go under View. Anything that is about
>>   communicating with (or handling nicknames of) dive computers should be
>>   in its own menu. As should anything that is talking to web sites.
>>
>>   I'd be curious what others think
>>
>
> Me too :)
>
>
>>
>> - The Dive Notes need to be editable in place. It looks like that's the
>>   case right now (since things aren't hooked up to any data it's
>>   somewhat hard to tell), but then how does 'undo' or 'apply' work.
>>   i.e., if the user edits a field, when does this get updated in our
>>   data structures? And is there a way to undo the last change?
>>   This is one of the major shortcomings in the Gtk GUI (where you have
>>   to open this extra window to edit things - but that of course gives
>>   you OK and Cancel buttons to handle "apply" and "undo"...)
>>
>
> I can make the fields reflects exactly what's in on the datastructure, it
> doesn't need to have an 'ok' or 'apply' button, when I'm editting, this is
> changing in the datastructure of yours, and undo & redo will work too. If
> you feel like a 'ok' or 'apply' button is needed, I can make some, but I
> don't think that's necessary. I think that when you edit and there's no
> need to save or apply, it's more intuitive for the user.

I don't think we need an ok/apply button. But I wonder how you will
implement the 'undo' or 'cancel' button as that is (IMHO) a needed
feature. 

>  a ctrl+z can be used to undo the last change.
>
> When you think it's right for a merge ? I of course didn't do all of the
> windows of the program, but a base that can be used by other programmers to
> hack on.
> As soon as I finish the Makefile integration I'll start the 'Open File'
> port.

I am happy to merge it in this state - assuming the Makefile is figured
out and the directory layout is agreed upon.

To reduce the noise, can we leave the C files in the main directory for
now and have the Qt UI in qt-ui  (qt-gui just feels odd to me)?


/D


More information about the subsurface mailing list